Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index file creation #37

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Conversation

unguiculus
Copy link
Member

Fixes a regression that would discard an existing index file
in the charts repo and always create a new one that only
contained newly released charts.

Signed-off-by: Reinhard Naegele unguiculus@gmail.com

Fixes a regression that would discard an existing index file
in the charts repo and always create a new one that only
contained newly released charts.

Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test rn but code lgtm 👍 since there's a new required value, I'd say this requires a MAJOR bump, but we're still on version zero 🤔

Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
@helm-bot helm-bot added size/L and removed size/M labels Jul 23, 2019
@unguiculus
Copy link
Member Author

no major bump 😉

Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
@unguiculus unguiculus merged commit d1fca78 into helm:master Jul 23, 2019
@unguiculus unguiculus deleted the fix-index-creation branch July 23, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants