enable contributions from forks #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattclegg Would you take a look at this one, please? I could not get the CI working in my fork with your changes, but the additional changes in this branch did work for me. |
mattclegg
reviewed
Aug 12, 2024
mattclegg
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
I can't confirm for the changes to magefile.go but the yml changes are correct.
@cpanato Are you able to check this please?
|
@mattclegg Would you please allow the checks to run? @cpanato Please let me know if I can assist with further testing or explanations. |
qrkourier
force-pushed
the
tweak-build
branch
from
92c1d6c to
809ce5e
Compare
|
LGTM but I don't have permission for the checks to run as I'm not a maintainer. |
|
@cpanato Would you like more explanation, examples, or testing for this? |
cpanato
reviewed
Sep 26, 2024
cpanato
reviewed
Sep 26, 2024
Signed-off-by: Kenneth Bingham <kenneth.bingham@netfoundry.io>
qrkourier
force-pushed
the
tweak-build
branch
from
bcf62eb to
68eadee
Compare
cpanato
approved these changes
Sep 26, 2024
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the modifications I needed to run Actions so I could send a pull request.