Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow #78

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Fix release workflow #78

merged 3 commits into from
Sep 2, 2020

Conversation

unguiculus
Copy link
Member

  • Install required tooling
  • Create Git tag locally instead of via GitHub API so Goreleaser
    can find it

Signed-off-by: Reinhard Nägele unguiculus@gmail.com

* Install required tooling
* Create Git tag locally instead of via GitHub API so Goreleaser
  can find it

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍 And love this improvement overall. I'm looking forward to seeing how this works for us. If all goes smoothly (no unanticipated gotchas etc) we may want to roll out something similar to other projects

@unguiculus
Copy link
Member Author

If all goes smoothly (no unanticipated gotchas etc) we may want to roll out something similar to other projects

Definitely. My plan was to do this next for chart-testing. Or, if anyone else wants to pick that up, feel free.

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
@unguiculus unguiculus merged commit 4f86929 into helm:master Sep 2, 2020
@unguiculus unguiculus deleted the feature/tagging branch October 5, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants