Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update releaser to regenerate generated field on index update #99

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

Niksko
Copy link
Contributor

@Niksko Niksko commented Jan 14, 2021

Currently, the only time the generated field is ever written is when we invoke the repo.NewIndexFile() method. This means that contrary to what you would expect, the generated field is not updated when the index is updated.

This adds a single line change that calls time.Now() after we have determined that the index is to be updated, and updates the generated field before the index is written.

Closes #90

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you squash the commit as well?

thanks for the fix

Currently, the only time the `generated` field is ever written is when
we invoke the repo.NewIndexFile() field. This means that contrary to
what you would expect, the `generated` field is not updated when the
index is updated.

This adds a single line change that calls `time.Now()` after we have
determined that the index is to be updated, and updates the `generated`
field before the index is written.

Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks!

@Niksko
Copy link
Contributor Author

Niksko commented Feb 7, 2021

Bump @unguiculus

@unguiculus unguiculus merged commit 4241b82 into helm:master Feb 8, 2021
@onedr0p
Copy link

onedr0p commented Feb 14, 2021

Any chance the maintainers here can do a release, are we waiting on something else before that happens?

@cpanato
Copy link
Member

cpanato commented Feb 14, 2021

@onedr0p I will check that next week

@onedr0p
Copy link

onedr0p commented Feb 14, 2021

Awesome and I just noticed someone created an issue for this, apologies for asking here.

#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update generated timestamp in index.yaml
5 participants