Update releaser to regenerate generated field on index update #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
reviewed
Jan 14, 2021
cpanato
requested changes
Jan 14, 2021
Currently, the only time the `generated` field is ever written is when we invoke the repo.NewIndexFile() field. This means that contrary to what you would expect, the `generated` field is not updated when the index is updated. This adds a single line change that calls `time.Now()` after we have determined that the index is to be updated, and updates the `generated` field before the index is written. Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>
|
Bump @unguiculus |
unguiculus
approved these changes
Feb 8, 2021
|
Any chance the maintainers here can do a release, are we waiting on something else before that happens? |
|
@onedr0p I will check that next week |
|
Awesome and I just noticed someone created an issue for this, apologies for asking here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only time the
generatedfield is ever written is when we invoke therepo.NewIndexFile()method. This means that contrary to what you would expect, thegeneratedfield is not updated when the index is updated.This adds a single line change that calls
time.Now()after we have determined that the index is to be updated, and updates thegeneratedfield before the index is written.Closes #90