fix: add unit to extra arg help message #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The help message for the --helm-extra-args config used an example without units, which caused to fail the next chart-testing run if just copy-pasted. Signed-off-by: Christopher Zell <zelldon91@googlemail.com>
cpanato
approved these changes
Mar 14, 2022
ilmax
pushed a commit
to ilmax/chart-testing
that referenced
this pull request
Mar 15, 2022
The help message for the --helm-extra-args config used an example without units, which caused to fail the next chart-testing run if just copy-pasted. Signed-off-by: Christopher Zell <zelldon91@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a unit (s == seconds) to the
--helm-extra-argshelp message.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #The help message for the
--helm-extra-argsconfig used an example without units,which caused to fail the next chart-testing run if just copy-pasted.
Special notes for your reviewer:
Might be related to newer go versions ? kubernetes/kubernetes#40783