feat(helm): Add support for OCI chart repositories #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can someone review this? we're adopting OCI and currently running this custom build as workaround |
|
bumping this up for visibility :) |
|
Can a maintainer look at this? It is a really small review that helps a lot of users. |
|
+1 on this feature |
|
@jcsf sorry for the delay here, can you rebase and fix the lint issues? |
Sure, will work on this today and update the PR. |
|
@cpanato Please retrigger the pipelines I believe the linter is fixed and the branch rebased. |
cpanato
requested changes
Oct 27, 2023
Signed-off-by: João Fernandes <jcsf_1995@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since Helm 3.8 the support of OCI registries is no longer experimental and is enabled by default, this means that more and more people will be using registries to store charts. In order to support this type of repository, a small change is needed because OCI registries can't be added like "regular repositories", and need to use a different command "helm registry login".
Therefore, and since it was already agreed that OCI repositories should start the URL with "oci://" this PR uses the prefix of the repository URL to select the right command to be able to add these type of repositories.
Special notes for your reviewer: I didn't added any automation test because didn't find any similar to what already was done, I tested this locally using a registry of mine.
Signed-off-by: João Fernandes jcsf_1995@hotmail.com