-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Set rollingUpdate to null when updateStrategy is Recreate #12319
Set rollingUpdate to null when updateStrategy is Recreate #12319
Conversation
Hi @minhdanh. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Minh Danh <minhdanh.ngo@gmail.com>
/assign @desaintmartin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this fix!
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juan131, minhdanh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Minh Danh <minhdanh.ngo@gmail.com>
Signed-off-by: Minh Danh <minhdanh.ngo@gmail.com>
Signed-off-by: Minh Danh <minhdanh.ngo@gmail.com> Signed-off-by: Kevin Duane <duank001@apps.disney.com>
Signed-off-by: Minh Danh <minhdanh.ngo@gmail.com>
What this PR does / why we need it:
This PR adds
"rollingUpdate": null
toupdateStrategy
of the statefulsets when the type of updateStrategy isRecreate
.This is needed in case someone initially uses the default strategy, which is
RollingUpdate
, but then decides to change it toRecreate
for some reason (such as pv mounting issue on some platforms).In that case they will not be able to update the strategy with such below error:
By adding
"rollingUpdate": null
, this will solve that issue.See also: kubernetes/kubernetes#24198
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]