-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[incubator/raw] Resource templates #12422
[incubator/raw] Resource templates #12422
Conversation
Hi @mumoshu. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@josdotso Hey! Would you mind reviewing this? Also, I've added myself as a another Chart reviewer/approver to helm maintain this chart. If you don't mind, please let me help 😄 |
/assign josdotso |
@josdotso: GitHub didn't allow me to assign the following users: josdotso. Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @josdotso |
@josdotso: GitHub didn't allow me to assign the following users: josdotso. Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ah well.. this looks awesome! haha. And thanks for the help on reviewing. /approve |
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets). Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
e917356
to
56d5b63
Compare
@josdotso Thanks for reviewing! I had to add a harmless raw resource in the default values.yaml charts/incubator/raw/values.yaml Lines 68 to 73 in 56d5b63
Perhaps there was't chart ci when you first authored this chart, that's why we didn't have one before. |
@josdotso Maybe putting /lgtm once again flows everything |
Thanks. Yes, I don't think CI was instituted at the time I authored this. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josdotso, mumoshu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@josdotso Thanks for the confirmation and reviewing |
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets). Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets). Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets). Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com> Signed-off-by: Kevin Duane <duank001@apps.disney.com>
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets). Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like helm-secrets.
Signed-off-by: Yusuke Kuoka ykuoka@gmail.com