Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/raw] Resource templates #12422

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Mar 21, 2019

This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like helm-secrets.

Signed-off-by: Yusuke Kuoka ykuoka@gmail.com

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mumoshu. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2019
@mumoshu
Copy link
Collaborator Author

mumoshu commented Mar 21, 2019

@josdotso Hey! Would you mind reviewing this?

Also, I've added myself as a another Chart reviewer/approver to helm maintain this chart. If you don't mind, please let me help 😄

@ghost
Copy link

ghost commented Mar 21, 2019

/assign josdotso

@k8s-ci-robot
Copy link
Contributor

@josdotso: GitHub didn't allow me to assign the following users: josdotso.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign josdotso

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link

ghost commented Mar 21, 2019

/assign @josdotso

@k8s-ci-robot
Copy link
Contributor

@josdotso: GitHub didn't allow me to assign the following users: josdotso.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @josdotso

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link

ghost commented Mar 21, 2019

Ah well.. this looks awesome! haha. And thanks for the help on reviewing.

/approve
/lgtm
/okay-to-test

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2019
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets).

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
@mumoshu mumoshu force-pushed the incubator-raw-resource-templates branch from e917356 to 56d5b63 Compare March 22, 2019 01:07
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2019
@mumoshu
Copy link
Collaborator Author

mumoshu commented Mar 22, 2019

@josdotso Thanks for reviewing! I had to add a harmless raw resource in the default values.yaml

# This is here to pass the chart ci
- |
apiVersion: v1
kind: ConfigMap
metadata:
name: raw
to pass the chart ci.

Perhaps there was't chart ci when you first authored this chart, that's why we didn't have one before.

@mumoshu
Copy link
Collaborator Author

mumoshu commented Mar 22, 2019

@josdotso Maybe putting /lgtm once again flows everything

@ghost
Copy link

ghost commented Mar 22, 2019

Thanks. Yes, I don't think CI was instituted at the time I authored this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josdotso, mumoshu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bdff987 into helm:master Mar 22, 2019
@mumoshu mumoshu deleted the incubator-raw-resource-templates branch March 22, 2019 07:46
@mumoshu
Copy link
Collaborator Author

mumoshu commented Mar 22, 2019

@josdotso Thanks for the confirmation and reviewing ☺️

rmccorm4 pushed a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets).

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets).

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets).

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Signed-off-by: Kevin Duane <duank001@apps.disney.com>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
This is handy when you basically want an adhoc helm chart that securely generates Kubernetes secrets with a tool like [helm-secrets](https://github.com/futuresimple/helm-secrets).

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants