-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[incubator/raw] fix: ConfigMap Artifact created for every raw chart #13633
[incubator/raw] fix: ConfigMap Artifact created for every raw chart #13633
Conversation
b6df67b
to
194cb9d
Compare
194cb9d
to
aebca29
Compare
Just wondering if I can /lgtm on this myself :) |
/lgtm |
@mumoshu: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
aebca29
to
6341a8a
Compare
@josdotso Would you mind reviewing this? Thanks! |
/lgtm Looks good to me. CI won't know who I am, but the PR looks good. Thanks for fixing this @mumoshu |
@dcwangmit01: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Thanks!
/lgtm |
6341a8a
to
3c0ada6
Compare
Fixes helm#13188 Signed-off-by: Yusuke KUOKA <ykuoka@gmail.com>
3c0ada6
to
e617faa
Compare
Bumped the chart version again to avoid the merge conflict. |
@josdotso Would you mind putting /lgtm once again? Thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcwangmit01, josdotso, mumoshu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…elm#13633) Fixes helm#13188 Signed-off-by: Yusuke KUOKA <ykuoka@gmail.com>
…elm#13633) Fixes helm#13188 Signed-off-by: Yusuke KUOKA <ykuoka@gmail.com>
What this PR does / why we need it:
This PR changes the default values.yaml to contain no items under
templates
. It had a dummy item just to pass the charts CI, but after reading the documentation ofct
, specifically https://github.com/helm/chart-testing/blob/acfb89768ede45c25fa6fa56ae345d23f68e4f82/doc/ct_install.md, I realized that it isn't needed at all. Instead, I addedci/templates-values.yaml
andci/resources-values.yaml
according to thect
convension, so thatct
would use those CI-specific values.yaml for testing.Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]