[stable/kured] feature: Add autolock to define when to execute kured

[mtparet]

What this PR does / why we need it:

Be able to define when to allow kured to be executed.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/chart])

[k8s-ci-robot]

Hi @mtparet. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtparet]

/assign @viglesiasce

[mtparet]

@plumdog @patrickmslatteryvt could you take a look at this PR ?

[plumdog]

@mtparet What is this feature and how does it work? I can't find it mentioned in https://github.com/weaveworks/kured anywhere. Is this an true feature of kured, or something that interacts with the locking configmap annotation that kured uses?

[plumdog]

Could make the two cronjobs use the same template (there's quite a bit of repetition between them, and they are "twins", so their sameness is inherent) which might be tidier, but might be harder to understand.

[mtparet]

Indeed but I tried but I don't know how to do that, using functions in .tpl file storing the whole template ?

[plumdog]

You can do this with something like:

{{ $root := . }}
{{- range $direction := list "lock" "unlock" }}
apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name: {{ template "kured.fullname" $root }}-{{ $direction }}
...
{{- if eq $direction "lock" }}
  schedule: {{ $root.Values.autolock.scheduleLock | quote }}
{{- else }}
  schedule: {{ $root.Values.autolock.scheduleUnlock | quote }}
{{- end }}
...
{{- end }}

But I'm inclined to say get it merged as it is, then we can worry about dry-ing up the templates later.

[patrickmslatteryvt]

Great idea while kubereboot/kured#66 is in PR limbo.
I know I'll certainly use it for my AKS clusters.

[patrickmslatteryvt]

@mtparet What is this feature and how does it work? I can't find it mentioned in https://github.com/weaveworks/kured anywhere. Is this an true feature of kured, or something that interacts with the locking configmap annotation that kured uses?

Yeah, I'd have to agree that some more explanation of how this works in the readme would greatly benefit new users.

[mtparet]

@patrickmslatteryvt @plumdog

I have added a short description of the feature and address some comments.

[mtparet]

As @plumdog approved the PR, should this one be automatically merged ? @cpanato @paulczar

[zanhsieh]

/ok-to-test

[mtparet]

@plumdog it seems there is /lgtm missing to get this PR merged :)

[cpanato]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, mtparet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maxkisung]

The configuration is a little confusing. Using the default values, does that mean kured will only run reboots between 4am and 6am utc?