-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/memcached] - Add .Release.Namespace #18719
Conversation
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
Hi @Lord-Y. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gtaylor @olemarkus Can you guys please have a look on my PR :) ? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Lord-Y, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
Signed-off-by: Lord-Y Lord-Y@users.noreply.github.com
What this PR does / why we need it:
Add .Release.Namespace in all yaml files as it's required when deploying with Spinnaker. Without this, the deployment will be done in default namespace instead of the one you are targetting.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)