Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/memcached] - Add .Release.Namespace #18719

Merged
merged 1 commit into from
Nov 8, 2019
Merged

[stable/memcached] - Add .Release.Namespace #18719

merged 1 commit into from
Nov 8, 2019

Conversation

Lord-Y
Copy link
Contributor

@Lord-Y Lord-Y commented Nov 8, 2019

Signed-off-by: Lord-Y Lord-Y@users.noreply.github.com

What this PR does / why we need it:

Add .Release.Namespace in all yaml files as it's required when deploying with Spinnaker. Without this, the deployment will be done in default namespace instead of the one you are targetting.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Lord-Y. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2019
@Lord-Y
Copy link
Contributor Author

Lord-Y commented Nov 8, 2019

@gtaylor @olemarkus Can you guys please have a look on my PR :) ?

@olemarkus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lord-Y, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit d56ca8c into helm:master Nov 8, 2019
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants