Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[sealed-secrets] Define a port name, required by Istio for traffic management #22829

Closed
wants to merge 1 commit into from
Closed

Conversation

binboum
Copy link

@binboum binboum commented Jun 16, 2020

Signed-off-by: Maxence Laude maxence@laude.pro

What this PR does / why we need it:

Define a port name, required by Istio for traffic management

Link : https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

…nagement.

Signed-off-by: Maxence Laude <maxence@laude.pro>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: binboum
To complete the pull request process, please assign olib963
You can assign the PR to them by writing /assign @olib963 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot requested a review from srueg June 16, 2020 23:27
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @binboum. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 16, 2020
@srueg
Copy link
Collaborator

srueg commented Jun 17, 2020

Unfortunately a named port on the service object will break the kubeseal client, see:
#22097
bitnami-labs/sealed-secrets#397 (comment)

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2020
@stale
Copy link

stale bot commented Aug 1, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants