This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/prometheus-operator] add secret-field-selector #23330
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following prometheus-operator/prometheus-operator#3355, add support for this new option. This should be released in v0.41.0.
This option is used to filter out secrets that are usually watched by the operator but not useful. This includes filtering out Helm V3 secrets which can cause significant CPU and Memory usage or to select only Prometheus Secret if you want to tag them all with a type (or any Field Selector actually).
Which issue this PR fixes
None
Special notes for your reviewer:
This should not introduce any breaking change and should work (not enable the option but not crash the operator) before
v0.41.0
. I did not version-gate the option for this reason.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)