[stable/kube-lego] Adding options, fixing lint, bumping default version #2571
Conversation
…tting default image to 0.1.5
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @venezia. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
For anyone wanting to look at differences between the versions 0.1.4 and 0.1.5... jetstack/kube-lego@0.1.4...0.1.5 |
|
@mattfarina: GitHub didn't allow me to request PR reviews from the following users: jackzampolin. Note that only kubernetes members can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stable/kube-lego/values.yaml
Outdated
| @@ -5,6 +5,7 @@ config: | |||
| ## Email address to use for registration with Let's Encrypt | |||
| ## | |||
| # LEGO_EMAIL: my@email.tld | |||
| LEGO_EMAIL: foo@bar.com | |||
There was a problem hiding this comment.
Should use example.com instead of bar.com. example.com is spec'd for this while bar.com is a live domain.
There was a problem hiding this comment.
Well this is news to me! Also there is actually a foo@bar.com https://bar.com/ Maybe leave it as an easter egg?
There was a problem hiding this comment.
See RFC 6761 for details. example in certain permutations is a reserved domain name.
There was a problem hiding this comment.
I changed it to foo@example.com - thanks!
This PR does a couple of things
LEGO_SUPPORTED_INGRESS_CLASS,LEGO_SUPPORTED_INGRESS_PROVIDER, andLEGO_DEFAULT_INGRESS_CLASSenvironmental variables.These are needed in solutions for multiple ingress controllers Issue 233 and Issue 189
These variables have been listed on the project page's README.md - and while they are useful to an unreleased fix, they're still useful regardless
Fixes lint by having LEGO_EMAIL no longer commented out
Bumps default version of kube-lego to 0.1.5
I bumped the chart version to v0.2.0 to indicate the additional options that are available.
LMK if there's any problems - thanks