[stable/rabbitmq] Rename RABBITMQ_VHOST

[arthur-c]

Rename RABBITMQ_VHOST to RABBITMQ_DEFAULT_VHOST to work with latest rabbitmq:3 images.
Source: https://hub.docker.com/_/rabbitmq/

Tested with helm version:

Client: &version.Version{SemVer:"v2.7.0", GitCommit:"08c1144f5eb3e3b636d9775617287cc26e53dba4", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.7.0", GitCommit:"08c1144f5eb3e3b636d9775617287cc26e53dba4", GitTreeState:"clean"}

and it's working well

=INFO REPORT==== 24-Nov-2017::14:24:19 ===
Adding vhost 'myvhost'

=INFO REPORT==== 24-Nov-2017::14:24:19 ===
Creating user 'guest'

=INFO REPORT==== 24-Nov-2017::14:24:19 ===
Setting user tags for user 'guest' to [administrator]

=INFO REPORT==== 24-Nov-2017::14:24:19 ===
Setting permissions for 'guest' in 'myvhost' to '.*', '.*', '.*'

With RABBITMQ_VHOST it sticks to /vhost when rabbitmqVhostis set to myvhost

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[unguiculus]

/ok-to-test

[unguiculus]

/lgtm

[colingabr]

This breaks vhosts for bitnami rabbitmq docker images, which are the default images for this chart. Refer to the bitnami repo https://github.com/bitnami/bitnami-docker-rabbitmq

• RABBITMQ_VHOST: RabbitMQ application vhost. Default: /

There are no references to RABBITMQ_DEFAULT_VHOST

root@q-rabbitmq-781131022-nbjm1:/# env | grep "VHOST"
RABBITMQ_VHOST=/
RABBITMQ_DEFAULT_VHOST=/foo
root@q-rabbitmq-781131022-nbjm1:/# rabbitmqctl list_vhosts
warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8. Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell)
Listing vhosts ...
/

[colingabr]

Here's the PR to restore this: #3363