Add Fluent Bit chart. #895

kfox1111 · 2017-04-06T18:56:11Z

This PR adds a chart for deploying Fluent Bit that
ships Kubernetes logs.

This change adds a chart for deploying Fluent Bit that ships Kubernetes logs.

k8s-ci-robot · 2017-04-06T18:56:19Z

Hi @kfox1111. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

linki · 2017-04-11T21:40:50Z

stable/fluent-bit/templates/config.yaml

+  name: {{ template "fullname" . }}-config
+  labels:
+    app: {{ template "fullname" . }}
+  namespace: {{ .Values.namespace }}


This should be left out of the yamls and passed to helm install --namespace foo on the CLI.

linki · 2017-04-11T21:42:04Z

stable/fluent-bit/templates/daemonset.yaml

+kind: DaemonSet
+metadata:
+  name: fluent-bit
+  namespace: {{ .Values.namespace }}


This should be left out of the yamls and passed to helm install --namespace foo on the CLI.

linki · 2017-04-11T21:44:11Z

stable/fluent-bit/values.yaml

+  fluent_bit:
+    repository: fluent/fluent-bit
+    tag: 0.11.2
+  pullPolicy: IfNotPresent


pullPolicy seems to be unused in this chart.

linki · 2017-04-11T21:44:21Z

stable/fluent-bit/values.yaml

+# enable if started in minikube.
+on_minikube: false
+
+namespace: kube-system


namespace should be kept out of the yamls.

linki · 2017-04-11T21:48:47Z

Hi @kfox1111, this charts is missing a NOTES.txt. Here's a good example from the Drupal chart.

linki · 2017-04-11T21:49:56Z

stable/fluent-bit/Chart.yaml

@@ -0,0 +1,13 @@
+name: fluent-bit
+version: 0.11.2
+description: Fluent Bit


Let's use a decription somewhere along their description on Github:

Fast and Lightweight Log/Data Forwarder for Linux, BSD and OSX

kfox1111 · 2017-04-11T23:35:49Z

@linki really not sure what to put in a NOTES.txt. Its just a log shipping daemonset.

kfox1111 · 2017-04-11T23:39:32Z

Thanks for the review. I've fixed all the raised issues but the NOTES.txt thing. Please let me know how to proceed there.

linki · 2017-04-12T08:33:48Z

Thanks @kfox1111. How about adding a note that deployment was successful and how to find and follow the logs of fluent-bit itself. Something like this maybe.

kfox1111 · 2017-04-12T18:16:52Z

@linki ok. I think this will address the issue. Thanks for the pointer.

edsiper · 2017-04-12T18:18:20Z

@kfox1111 I've just released image tag 0.11.3, it contains a fix for forward mode.

linki · 2017-04-12T20:55:48Z

stable/fluent-bit/values.yaml

+  fluent_bit:
+    repository: fluent/fluent-bit
+    tag: 0.11.3
+  pullPolicy: IfNotPresent


pullPolicy is not used in daemonset.yaml

luxas · 2017-04-30T07:44:47Z

ping @kfox1111 any update on this PR? Would be cool to get in ;)

I think that charts should start in the incubation channel, does that sound good to you?

kfox1111 · 2017-05-01T16:05:41Z

I think the ball is in other folks court to allow it to merge? I'm not sure the process, nor if I need to do anything else to the ps.

seanknox · 2017-05-04T03:23:58Z

@k8s-bot ok to test

k8s-ci-robot · 2017-05-04T03:25:22Z

@kfox1111: The following test(s) failed:

Test name	Commit	Details	Rerun command
Jenkins Charts e2e	`8211b01`	link	`@k8s-bot e2e test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

viglesiasce · 2017-05-10T19:39:14Z

@kfox1111 can you give a look at why this is failing to install?

W0503 20:24:55.745] Error: release fluent--1465 failed: error validating "": error validating data: expected type array, for field spec.template.spec.containers[0].env, got map

edsiper · 2017-05-24T22:55:08Z

Please upgrade Fluent Bit to v0.11.6, it comes with proper X-Pack support for Elasticsearch

kfox1111 · 2017-05-31T23:40:06Z

Anything else needing to be done for this?

edsiper · 2017-05-31T23:44:04Z

Upgrade to v0.11.7 XD

prydonius · 2017-06-02T13:20:31Z

stable/fluent-bit/Chart.yaml

@@ -0,0 +1,13 @@
+name: fluent-bit
+version: 0.11.7


This should be the appVersion, the chart version should be 0.1.0

prydonius · 2017-06-02T13:21:36Z

stable/fluent-bit/templates/_helpers.tpl

+Expand the name of the chart.
+*/}}
+{{- define "name" -}}
+{{- default .Chart.Name .Values.nameOverride | trunc 63 -}}


add trimSuffix "-" at the end

- add appVersion, icon and home - update maintainers to use github ids

* upstream/master: Add Fluent Bit chart. (helm#895) Existing PVC support for stable/drupal (helm#1084) [stable/nginx-ingress] - Adding in support for the publish-service parameter (helm#975) [stable/prometheus] Add extraHostPathMounts config (helm#862)

* Add Fluent Bit chart. This change adds a chart for deploying Fluent Bit that ships Kubernetes logs. * Fix some misnamed entries. * Add forwarder Retry_Limit * Remove namespace. Update description. * Add Notes.txt * Bump version to 0.11.3 * Add missing imagePullPolicy * Fix wrong values datatype for env. * Bump version to 0.11.6 * Bump fluent-bit version. * Update Chart.yaml - add appVersion, icon and home - update maintainers to use github ids * add trimSuffix to helpers

Add Fluent Bit chart.

a23637a

This change adds a chart for deploying Fluent Bit that ships Kubernetes logs.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2017

kfox1111 added 2 commits April 6, 2017 12:44

Fix some misnamed entries.

3a17062

Add forwarder Retry_Limit

fbf64d0

linki reviewed Apr 11, 2017

View reviewed changes

Remove namespace. Update description.

f17e96c

linki added awaiting review changes needed size/medium labels Apr 12, 2017

Add Notes.txt

16bc40f

Bump version to 0.11.3

aad4080

linki reviewed Apr 12, 2017

View reviewed changes

Add missing imagePullPolicy

8211b01

linki added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2017

edsiper mentioned this pull request Apr 19, 2017

Helm Package fluent/fluentd-kubernetes-daemonset#8

Closed

luxas mentioned this pull request Apr 30, 2017

Use fluentbit+elasticsearch as the logging solution luxas/kubeadm-workshop#13

Open

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2017

viglesiasce removed the awaiting review label May 10, 2017

Fix wrong values datatype for env.

bdbb9fb

Bump version to 0.11.6

5280b16

Bump fluent-bit version.

ca8df5a

prydonius reviewed Jun 2, 2017

View reviewed changes

prydonius added 2 commits June 2, 2017 15:28

Update Chart.yaml

27be85a

- add appVersion, icon and home - update maintainers to use github ids

add trimSuffix to helpers

d03bfb1

prydonius added code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed and removed changes needed labels Jun 2, 2017

prydonius merged commit 9d3676a into helm:master Jun 2, 2017

kfox1111 deleted the fluent-bit branch June 2, 2017 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Fluent Bit chart. #895

Add Fluent Bit chart. #895

kfox1111 commented Apr 6, 2017

k8s-ci-robot commented Apr 6, 2017

linki Apr 11, 2017

linki Apr 11, 2017

linki Apr 11, 2017

linki Apr 11, 2017 •

edited

Loading

linki commented Apr 11, 2017

linki Apr 11, 2017

kfox1111 commented Apr 11, 2017

kfox1111 commented Apr 11, 2017

linki commented Apr 12, 2017 •

edited

Loading

kfox1111 commented Apr 12, 2017

edsiper commented Apr 12, 2017

linki Apr 12, 2017

luxas commented Apr 30, 2017

kfox1111 commented May 1, 2017

seanknox commented May 4, 2017

k8s-ci-robot commented May 4, 2017 •

edited

Loading

viglesiasce commented May 10, 2017

edsiper commented May 24, 2017

kfox1111 commented May 31, 2017

edsiper commented May 31, 2017

prydonius Jun 2, 2017

prydonius Jun 2, 2017

Add Fluent Bit chart. #895

Add Fluent Bit chart. #895

Conversation

kfox1111 commented Apr 6, 2017

k8s-ci-robot commented Apr 6, 2017

linki Apr 11, 2017

Choose a reason for hiding this comment

linki Apr 11, 2017

Choose a reason for hiding this comment

linki Apr 11, 2017

Choose a reason for hiding this comment

linki Apr 11, 2017 • edited Loading

Choose a reason for hiding this comment

linki commented Apr 11, 2017

linki Apr 11, 2017

Choose a reason for hiding this comment

kfox1111 commented Apr 11, 2017

kfox1111 commented Apr 11, 2017

linki commented Apr 12, 2017 • edited Loading

kfox1111 commented Apr 12, 2017

edsiper commented Apr 12, 2017

linki Apr 12, 2017

Choose a reason for hiding this comment

luxas commented Apr 30, 2017

kfox1111 commented May 1, 2017

seanknox commented May 4, 2017

k8s-ci-robot commented May 4, 2017 • edited Loading

viglesiasce commented May 10, 2017

edsiper commented May 24, 2017

kfox1111 commented May 31, 2017

edsiper commented May 31, 2017

prydonius Jun 2, 2017

Choose a reason for hiding this comment

prydonius Jun 2, 2017

Choose a reason for hiding this comment

linki Apr 11, 2017 •

edited

Loading

linki commented Apr 12, 2017 •

edited

Loading

k8s-ci-robot commented May 4, 2017 •

edited

Loading