Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm org Code of Conduct #61

Closed
scottrigby opened this issue Nov 8, 2018 · 12 comments
Closed

Helm org Code of Conduct #61

scottrigby opened this issue Nov 8, 2018 · 12 comments

Comments

@scottrigby
Copy link
Member

scottrigby commented Nov 8, 2018

Question

Helm repos that have a code-of-conduct file still point to the Kubernetes CoC (which in turn points to the CNCF one). Since we're no longer under k8s, and some of the Helm repos don't have a CoC file at all, how should we address this?

Proposal

Ensure all Helm org repos include a file stating the existing policy that it must follow the CNCF Code of Conduct, with a direct link.

Current status

✅Approved (see issue thread). PRs have been opened in all relevant Helm org repos, removing the k8s layer of indirection, and fills the gaps where there wasn't a CoC file at all.

Original issue

The chart-testing/code-of-conduct.md file was accidentally removed in #35 (thanks @nvtkaszpir for noticing). Adding this issue to make sure we add it back to master.

@unguiculus
Copy link
Member

We probably need a new code of conduct for the whole Helm org. The existing one still refers to the K8s one.

See https://github.com/helm/helm/blob/master/code-of-conduct.md

@scottrigby
Copy link
Member Author

scottrigby commented Nov 8, 2018

I was wondering the same… should we add it back in this repo though in the meantime, so we have something until the helm org updates that for all helm projects? Is this something we should cover in a governance meeting?

@unguiculus
Copy link
Member

Probably

@technosophos
Copy link
Member

I believe we are required to at least enforce the CNCF CoC, though we can add additional things if the CNCF approves. I'll defer to @michelleN who has worked on this part of CNCF.

@scottrigby
Copy link
Member Author

scottrigby commented Nov 9, 2018

Hey @technosophos good idea 👍

In Keybase I asked about the process for this (updating Helm projects' CoC, for example, to the Contributor Covenant), where @mattfarina also suggested posting to the Helm Maintainers list per the governance doc.

So… this is fun… I just quickly looked through all the Helm org repos:

  • All those that have CoC files at all still point to the k8s community CoC (many don't have a CoC file)
  • The k8s community CoC just points to the CNCF CoC
  • The CNCF CoC is adapted from the Contributor Covenant already 🎉

My 2¢ is we should add a central Helm CoC file (in the Helm community repo) which points directly to the CNCF CoC, and then add files in each Helm org repo pointing to the central Helm one (same as kubernetes/kubernetes does). I'll reach out to @michelleN, and post to the maintainers list, and see what everyone thinks 😄

@michelleN
Copy link
Member

yep that sounds great @scottrigby! +1 from me

scottrigby referenced this issue in scottrigby/chart-testing Nov 9, 2018
Signed-off-by: Scott Rigby <scott@r6by.com>
@scottrigby
Copy link
Member Author

@mattfarina suggested removing one more layer of indirection: each helm org repo can just link directly to CNCF CoC rather than a central Helm one linking there. Sounds good to me!

K8s never extended the CNCF CoC, so we likely won't need to either. But if we ever do need to we can always add that layer of indirection back 😜

Here's a PR, pending Helm project maintainer consensus (of whatever type we need for this): helm/chart-testing#49

scottrigby referenced this issue in scottrigby/monocular Nov 9, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
@viglesiasce
Copy link

Linking to the CNCF CoC directly SGTM.

scottrigby referenced this issue in helm/helm Nov 9, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/chartmuseum Nov 10, 2018
scottrigby referenced this issue in scottrigby/helm-www Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/repo-audit Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/charts-check-pr-title Nov 10, 2018
scottrigby referenced this issue in scottrigby/charts-check-pr-title Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/pull-sizer Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/github-webhook-dco-labeler Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/query-store-quay-logs Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/helm-hub Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/specs Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/charts-tooling Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/rudder-appcontroller Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/helm-summit-notes Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby referenced this issue in scottrigby/prow Nov 10, 2018
See https://github.com/helm/chart-testing/issues/48

Signed-off-by: Scott Rigby <scott@r6by.com>
@scottrigby
Copy link
Member Author

I added PRs for all helm org repos, except rudder-federation (because it's Archived), and the 3 "OBSOLETE" repos: charts-classic, helm-classic, and get-helm (BTW should we archive those as well?).

@scottrigby scottrigby transferred this issue from helm/chart-testing Nov 11, 2018
@scottrigby
Copy link
Member Author

scottrigby commented Nov 11, 2018

PS I moved this issue to the helm/community repo because it grew in scope. And also, because now we can! 🙌

@scottrigby scottrigby changed the title Re-add code of conduct Helm org Code of Conduct Nov 11, 2018
@scottrigby
Copy link
Member Author

This is now accepted. It was not initially clear to everyone (from Decision Making at the Helm org level) whether this needed a supermajority or if lazy consensus was OK. By the time we decided we only needed lazy consensus, we had a supermajority anyway 😅 I'll remove the pending status from the linked PRs.

@scottrigby
Copy link
Member Author

This is now complete ✅ 🙌 Thanks everyone!

I've asked about the obsolete repo question above, and have a Helm Maintainers list thread started for it. Will open a new issue to track that one once we get some feedback there.

scottrigby added a commit to scottrigby/chart-releaser that referenced this issue Feb 7, 2019
Signed-off-by: Scott Rigby <scott@r6by.com>
unguiculus pushed a commit to helm/chart-releaser that referenced this issue Feb 7, 2019
Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby added a commit to helm/chart-releaser that referenced this issue Feb 7, 2019
Signed-off-by: Scott Rigby <scott@r6by.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants