Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm-secrets #597

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Add helm-secrets #597

merged 1 commit into from
Jun 8, 2020

Conversation

jkroepke
Copy link
Contributor

Hi,

as in #567 mentioned correctly the helm-secrets project gets inactive.

helm-secrets is a great plugin because with you want to store secret in an encrypted format. encryption on rest is default compliance rule in a lot of companies in germany.

Since is this mandatory for us I will continue to maintain it.

URL to project: https://github.com/jkroepke/helm-secrets

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@mattfarina
Copy link
Contributor

Is this still deprecated? It looks to be at a new location... https://github.com/zendesk/helm-secrets and there is no deprecation notice. There was a recent commit (though only one). With the two versions diverge from each other? I ask because I'm wondering if both should be listed or we should handle this a different way.

@jkroepke
Copy link
Contributor Author

jkroepke commented Apr 27, 2020

Is this still deprecated?

It was never deprecated but I didn't see any activity at least for one year. Now it looks zendesk gets the ownership of the repo but there are no public announcements about this nor any other activity on issues or pull requests.

We could list both projects like the community exporter list on the prometheus wiki does it.

With the two versions diverge from each other?

Yep. See: jkroepke/helm-secrets#1

The concept is still the same (shell based and using sops as engine) but I change already a lot of implantation details. An exchange secrets engine should be the next goal.

@jkroepke
Copy link
Contributor Author

Hi @mattfarina ,

I add recently vault support which means the two versions are now diverge from each other. jkroepke/helm-secrets resolved a lot of opened issues that are reported at the zendesk repositroy.

I would propose to add jkroepke/helm-secrets independently from current state of zendesk/helm-secrets.

The status of the maintenance is still unknown for me. A lot of issues or pull requests are not reviewed or accepted for months while a new maintainer committed to just update the copyright files.

I personally declare the repository as abandoned or inactive. That's the reason to fork the repos and I want to announce this to the community of helm.

References: zendesk/helm-secrets#100

Copy link
Member

@bridgetkromhout bridgetkromhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it does appear the original project is inactive. Thanks!

@bridgetkromhout bridgetkromhout merged commit f015d54 into helm:master Jun 8, 2020
@jkroepke jkroepke deleted the patch-2 branch June 8, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants