-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: options to configure local registry #113
base: main
Are you sure you want to change the base?
Conversation
12cb1e9
to
becd144
Compare
.github/workflows/test.yaml
Outdated
local_reg=custom-registry:5001 | ||
|
||
docker pull busybox | ||
docker tag busybox $local_reg/localbusybox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where this $local_reg
come from?
we need to use the github actions syntax and export that as github output, otherwise people will not know how to get that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes agree! I updated the action to export the registry address (registry-name:registry-port
) at LOCAL_REGISTRY
env var. How about now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or would you prefer the it as step output instead?
That being said I think I misunderstood your suggestion. The github output seems like a better and more flexible option here as it avoids any conflicts in env vars. How about now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok, just need to revisit the local registry env var to follow github actions best practices
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Fixes #76
Description
Add options to configure an insecure local registry. An example workflow file can be:
Does this look alright?
Credits: Thanks https://github.com/container-tools/kind-action for providing the inspiration.