Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: options to configure local registry #113

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

tthvo
Copy link
Contributor

@tthvo tthvo commented May 9, 2024

Fixes #76

Description

Add options to configure an insecure local registry. An example workflow file can be:

name: Create Cluster with Registry

on: pull_request

jobs:
  create-cluster-with-registry:
    runs-on: ubuntu-latest
    steps:
      - name: Kubernetes KinD Cluster
        uses: helm/kind-action@v1
        with:
          registry: true
          registry_name: my-registry
          registry_port: 5001
          registry_enable_delete: true

Does this look alright?

Credits: Thanks https://github.com/container-tools/kind-action for providing the inspiration.

@tthvo tthvo force-pushed the local-registry branch 2 times, most recently from 12cb1e9 to becd144 Compare May 10, 2024 20:32
@cpanato cpanato requested a review from davidkarlsen May 13, 2024 08:25
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok, just need to revisit the local registry env var to follow github actions best practices

@tthvo
Copy link
Contributor Author

tthvo commented Nov 19, 2024

Hi @cpanato @davidkarlsen, any further comments?

@cpanato
Copy link
Member

cpanato commented Dec 17, 2024

seems good
@tthvo can you please rebase and fix the conflicts then we can get this merged?

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo
Copy link
Contributor Author

tthvo commented Dec 18, 2024

Rebased now. Thanks!

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

lets merge and test in the main branch

@cpanato cpanato merged commit 9315f6b into helm:main Dec 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: local registry
2 participants