-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: options to configure local registry #113
Conversation
12cb1e9
to
becd144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok, just need to revisit the local registry env var to follow github actions best practices
1b83770
to
5af014a
Compare
Hi @cpanato @davidkarlsen, any further comments? |
seems good |
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
5af014a
to
fc5148f
Compare
Rebased now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
lets merge and test in the main branch
Fixes #76
Description
Add options to configure an insecure local registry. An example workflow file can be:
Does this look alright?
Credits: Thanks https://github.com/container-tools/kind-action for providing the inspiration.