This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
Use components and expose multiple package versions. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove f-string to make ci happy ugh
Janos95
force-pushed
the
stable/2020.06
branch
from
5c43f01
to
151dd5c
Compare
|
It fails to build on clang (issue linking stl) and on appveyor (shared/static missmatch). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey as noted here, I think it
would be great to have a more seamless cmake integration. I've added the appropriate components, though there might need to be some more thought for how to enable/disable individual components. The 'Containers'
and the 'Utility' component depend cyclically on each other, and there are a couple of components depending of the 'Containers' component. At the moment everything works fine for me on linux, but one could think about modeling those realations more closely (e.g. enabling the Utility component when someone enable the Interconnect component).