Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename keepdim to keepdims #1006

Closed
neosunhan opened this issue Aug 17, 2022 · 0 comments · Fixed by #1008
Closed

Rename keepdim to keepdims #1006

neosunhan opened this issue Aug 17, 2022 · 0 comments · Fixed by #1008
Assignees
@neosunhan
Labels
API Anything relating the API GSoC

Comments

@neosunhan
Copy link
Collaborator

neosunhan commented Aug 17, 2022 •
edited
Loading

numpy uses keepdims in their functions. The keepdim argument of corresponding Heat functions should be renamed to follow the numpy API.

Affected functions:

  • prod
@neosunhan neosunhan added API Anything relating the API GSoC labels Aug 17, 2022
@neosunhan neosunhan self-assigned this Aug 17, 2022
@neosunhan neosunhan mentioned this issue Aug 18, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neosunhan neosunhan

Labels
API Anything relating the API GSoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: Rename keepdim kwarg to keepdims helmholtz-analytics/heat
1 participant
@neosunhan