-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Rename keepdim
kwarg to keepdims
#1008
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1008 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 72 72
Lines 10485 10485
=======================================
Hits 9623 9623
Misses 862 862
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
keepdim
kwargkeepdim
kwarg to keepdims
…tz-analytics/heat into api/1006-rename-keepdim-keepdims
Thank you for the PR! |
@neosunhan @mtar I'm done here. I've renamed Thanks again @neosunhan for the great work! |
Description
Renames
keepdim
kwarg tokeepdims
, in accordance with the numpy API.Affected functions:
prod
sum
all
any
max
median
min
percentile
vecdot
logsumexp
Issue/s resolved: #1006
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no
skip ci