Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement modf() #125

Closed
Markus-Goetz opened this issue Feb 21, 2019 · 3 comments · Fixed by #402
Closed

Implement modf() #125

Markus-Goetz opened this issue Feb 21, 2019 · 3 comments · Fixed by #402
Assignees
@lenablind
Labels
good first issue Good for newcomers

Comments

@Markus-Goetz
Copy link
Member

No description provided.

@Markus-Goetz Markus-Goetz added the good first issue Good for newcomers label Feb 21, 2019
@coquelin77
Copy link
Member

is this intended to be the same as torch.fmod?

@TheSlimvReal
Copy link
Contributor

I suppose this can be closed due to #196 which implemented mod and fmod?

@Markus-Goetz
Copy link
Member Author

This is indeed different from fmod() as it returns fractional and integral part. See also

https://docs.scipy.org/doc/numpy/reference/generated/numpy.modf.html

@lenablind lenablind self-assigned this Sep 30, 2019
@lenablind lenablind mentioned this issue Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenablind lenablind

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Features/125 modf helmholtz-analytics/heat
4 participants
@Markus-Goetz @coquelin77 @TheSlimvReal @lenablind