Features/125 modf #402
Features/125 modf #402
Conversation
heat/core/rounding.py
Outdated
| tensor([ 0.0000, -0.6000, -0.2000, -0.8000, -0.4000, 0.0000, 0.4000, 0.8000, 0.2000, 0.6000])) | ||
| """ | ||
|
|
||
| integralParts = ht.trunc(x) |
There was a problem hiding this comment.
dont need ht.trunc, should just be trunc(x)
in the future please avoid using ht.function() as it causes a cyclic import. instead use the form: file.function()
heat/core/rounding.py
Outdated
| @@ -1,10 +1,11 @@ | |||
| import torch | |||
| import heat as ht | |||
heat/core/tests/test_rounding.py
Outdated
| self.assertIsInstance(float64_modf[1], ht.DNDarray) | ||
| self.assertEqual(float64_modf[0].dtype, ht.float64) | ||
| self.assertEqual(float64_modf[1].dtype, ht.float64) | ||
| self.assertTrue((x for x in float32_modf[0]._DNDarray__array) == y for y in comparison[0]) |
There was a problem hiding this comment.
while technically correct, a neater way to do this might be to use ht.all(tensor == ht.array(comparison)) or torch.all as you use in the test_round function
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 98.05% 98.07% +0.01%
==========================================
Files 55 55
Lines 11285 11414 +129
==========================================
+ Hits 11066 11194 +128
- Misses 219 220 +1
Continue to review full report at Codecov.
|
|
bump, coverage needs to be a bit higher. if you need help seeing where let me know, sometimes the codecov site doesnt show things right away |
@coquelin77 Thank you for your offer! Let's see if I can do this, otherwise I'll seek you out. |
…assert_array_equal()
…t.arange(start, end, step, etc....) with ht.array(comparison, split=0).
heat/core/tests/test_rounding.py
Outdated
| self.assertIsInstance(float64_round_distrbd, ht.DNDarray) | ||
| self.assertEqual(float64_round_distrbd.dtype, ht.float64) | ||
| self.assertEqual(float64_round_distrbd.dtype, ht.float64) | ||
| BasicTest.assert_array_equal(self, float64_round_distrbd, comparison) |
There was a problem hiding this comment.
It's better to extend the BasicTest class and then use self.assert_array_equal. This way self does not need to be passed additionally.
heat/core/tests/test_rounding.py
Outdated
| @@ -3,6 +3,8 @@ | |||
| import numpy as np | |||
| import heat as ht | |||
|
|
|||
| from heat.core.tests.test_suites.basic_test import BasicTest | |||
|
|
|||
|
|
|||
| class TestRounding(unittest.TestCase): | |||
There was a problem hiding this comment.
The BasicTest class is meant as an extension to the unittest.TestCase class and should therefore be extended when you want to use it.
There was a problem hiding this comment.
Thank you for your feedback! I tried to implement your requested changes.
|
Thank you @ClaudiaComito ! |
Description
Concerned issues:
#125 (modf),
#126 (round)
#125 modf
Implementation of modf (following the example set by numpy)
Addition of the function to be used as an attribute
Test function for modf
#126 round
Implementation of round
Addition of the function to be used as an attribute
Test function for round
Special dependencies required: None, same as for heat
Fixes: #125 (modf), #126 (round)
Changes proposed:
Type of change
Select relevant options.
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
Are all split configurations tested and accounted for?
[ ] yes [x] no
Does this change require a documentation update outside of the changes proposed?
[ ] yes [x] no
Does this change modify the behaviour of other functions?
[ ] yes [x] no
Are there code practices which require justification?
[x] yes [ ] no