Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement digitize/bucketize #926

Closed
mtar opened this issue Mar 2, 2022 · 0 comments · Fixed by #928
Closed

implement digitize/bucketize #926

mtar opened this issue Mar 2, 2022 · 0 comments · Fixed by #928
Assignees
@mtar
Labels
enhancement New feature or request

Comments

@mtar
Copy link
Collaborator

mtar commented Mar 2, 2022 •
edited
Loading

Feature functionality
A clear and concise description of what the feature should do exactly and any alternative solutions.

An implementation of digitize (NumPy) or bucketize (PyTorch)

Additional context
Add any other context or screenshots about the feature request here.

As the function is called in NumPy and PyTorch quite differently, we should support both names.
@mtar mtar added the enhancement New feature or request label Mar 2, 2022
@mtar mtar self-assigned this Mar 2, 2022
mtar added a commit that referenced this issue Mar 4, 2022
@mtar
implement digitize/bucketize
c27df91 
Fixes #926
@mtar mtar mentioned this issue Mar 4, 2022
Merged
4 tasks
ClaudiaComito added a commit that referenced this issue Apr 20, 2022
@mtar @ClaudiaComito
add digitize/bucketize (#928)
416006e 
* implement digitize/bucketize
Fixes #926

* update tests

* update tests

* Apply suggestions from code review

* Update heat/core/statistics.py

* Small docs edit

Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtar mtar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add digitize/bucketize helmholtz-analytics/heat
1 participant
@mtar