Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed weighted average() along tuple of axes: shape of weights to match shape of input #1037

Merged
merged 6 commits into from
Jan 30, 2023

Conversation

Mystic-Slice
Copy link
Collaborator

@Mystic-Slice Mystic-Slice commented Oct 22, 2022

Issue/s resolved: #351

Type of change

Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes / no

skip ci

@ghost
Copy link

ghost commented Oct 22, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #1037 (ba3cb59) into main (62410e7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          72       72           
  Lines       10438    10438           
=======================================
  Hits         9582     9582           
  Misses        856      856           
Flag Coverage Δ
unit 91.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/statistics.py 96.88% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ClaudiaComito
Copy link
Contributor

@Mystic-Slice this PR has been forgotten it seems. Sorry about this. Will up merge the latest main? I think we can merge on Monday. Thanks and apologies!

@Mystic-Slice
Copy link
Collaborator Author

Done!

@ClaudiaComito ClaudiaComito added API Anything relating the API bug Something isn't working documentation Anything related to documentation and removed bug Something isn't working labels Jan 30, 2023
@ClaudiaComito ClaudiaComito changed the title fix #351: Solution 1: enforce weights.shape = x.shape for tuple axis Distributed weighted average() along tuple of axes: shape of weights to match shape of input Jan 30, 2023
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for taking so long @Mystic-Slice and thanks!

@ClaudiaComito ClaudiaComito merged commit 6e5ab15 into main Jan 30, 2023
@ClaudiaComito ClaudiaComito deleted the RestrictWeightShape branch January 30, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Anything relating the API documentation Anything related to documentation GSoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ht.average() should allow weighted average across multiple axes
2 participants