-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add __eq__ to Device #1063
add __eq__ to Device #1063
Conversation
👇 Click on the image for a new way to code review
Legend |
Codecov Report
@@ Coverage Diff @@
## main #1063 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 72 72
Lines 10403 10409 +6
=======================================
+ Hits 9549 9555 +6
Misses 854 854
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @mtar!
Description
This PR overloads the '==' operator such that devices can be compared locally.
Issue/s resolved: #1062
Changes proposed:
__eq__
operatorType of change
Memory requirements
n/a
Performance
n/a
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no