Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around for pre-commit ci failure #1103

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Work-around for pre-commit ci failure #1103

merged 1 commit into from
Feb 15, 2023

Conversation

Mystic-Slice
Copy link
Collaborator

@Mystic-Slice Mystic-Slice commented Feb 13, 2023

Description

Black and Pydocstyle have conflicting requirements of code style. Probably due to the new release of black. Found a work-around in this comment.
image
black wants an empty line before the internal function. pydocstyle does not want an empty line after docstring.

@ghost
Copy link

ghost commented Feb 13, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1103 (abf7602) into main (db93bd3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1103   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          72       72           
  Lines       10519    10519           
=======================================
  Hits         9657     9657           
  Misses        862      862           
Flag Coverage Δ
unit 91.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/manipulations.py 98.63% <ø> (ø)
heat/core/tests/test_suites/basic_test.py 98.07% <ø> (ø)
heat/nn/data_parallel.py 84.13% <ø> (ø)
heat/regression/lasso.py 92.42% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 brilliant in its simplicity. Thank you @Mystic-Slice.

@ClaudiaComito ClaudiaComito added the bug Something isn't working label Feb 15, 2023
@ClaudiaComito ClaudiaComito added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit d090afa Feb 15, 2023
@ClaudiaComito ClaudiaComito deleted the FixPreCommitCI branch February 15, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants