-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflows for PRs #1114
add workflows for PRs #1114
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
+ Coverage 91.80% 91.83% +0.02%
==========================================
Files 72 72
Lines 10520 10520
==========================================
+ Hits 9658 9661 +3
+ Misses 862 859 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
||
on: | ||
pull_request: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a path-ignore:
filter for workflows and docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do it. We will have to bypass the branch protection then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then let's not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any issues with that. These kind of PRs are not common and don't have any impact on the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mtar , it looks good to me, I only have minor comments but as far as I'm concerned we can merge this.
By the way, we probably need two different PRs, this one with base |
3d9cbc0
to
54775ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging to main
Description
Adds workflows that get activated when a new PR is created. Runs a unit test on a single process and returns a message on success. The local PR branch is then send to the mirrored repository.
Pushes on the main and release branches are mirrored only to avoid double testing of branches/PR on the upstream repository.
Issue/s resolved: #1113
Changes proposed:
Type of change