Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflows for PRs #1114

Merged
merged 7 commits into from
Mar 17, 2023
Merged

add workflows for PRs #1114

merged 7 commits into from
Mar 17, 2023

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Feb 23, 2023

Description

Adds workflows that get activated when a new PR is created. Runs a unit test on a single process and returns a message on success. The local PR branch is then send to the mirrored repository.

Pushes on the main and release branches are mirrored only to avoid double testing of branches/PR on the upstream repository.

Issue/s resolved: #1113

Changes proposed:

  • add workflows for PRs
  • update existing workflow for mirroring

Type of change

  • workflow update

@mtar mtar added the workflows label Feb 23, 2023
@ghost
Copy link

ghost commented Feb 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@mtar mtar marked this pull request as ready for review February 28, 2023 14:19
@mtar mtar marked this pull request as draft March 2, 2023 09:45
@mtar mtar marked this pull request as ready for review March 8, 2023 10:25
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1114 (57d0e05) into main (5d6b6d5) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 57d0e05 differs from pull request most recent head 54775ca. Consider uploading reports for the commit 54775ca to get more accurate results

@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   91.80%   91.83%   +0.02%     
==========================================
  Files          72       72              
  Lines       10520    10520              
==========================================
+ Hits         9658     9661       +3     
+ Misses        862      859       -3     
Flag Coverage Δ
unit 91.83% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more


on:
pull_request:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a path-ignore: filter for workflows and docs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do it. We will have to bypass the branch protection then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then let's not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any issues with that. These kind of PRs are not common and don't have any impact on the tests.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mtar , it looks good to me, I only have minor comments but as far as I'm concerned we can merge this.

@ClaudiaComito
Copy link
Contributor

By the way, we probably need two different PRs, this one with base main and another one with base release/1.2.x.
Alternative: merge this PR into release/1.2.x and then release/... into main.

@mtar mtar changed the base branch from main to release/1.2.x March 17, 2023 09:43
@mtar mtar changed the base branch from release/1.2.x to main March 17, 2023 09:46
ClaudiaComito
ClaudiaComito previously approved these changes Mar 17, 2023
@ClaudiaComito ClaudiaComito changed the base branch from main to release/1.2.x March 17, 2023 10:50
@ClaudiaComito ClaudiaComito changed the base branch from release/1.2.x to main March 17, 2023 11:11
@ClaudiaComito ClaudiaComito dismissed their stale review March 17, 2023 11:11

The base branch was changed.

@ClaudiaComito ClaudiaComito changed the base branch from main to release/1.2.x March 17, 2023 11:13
@ClaudiaComito ClaudiaComito changed the base branch from release/1.2.x to main March 17, 2023 11:16
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to main

@ClaudiaComito ClaudiaComito merged commit d744909 into main Mar 17, 2023
@ClaudiaComito ClaudiaComito deleted the enhancement/1113-fork-actions branch March 17, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action from Fork PR
2 participants