Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pr workflow #1127

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Mar 21, 2023

Description

Adds an updated version of the workflows used in main with a minor fix.

Issue/s resolved: #1113

Changes proposed:

  • add ReceivePR.yml
  • add CommentPR.yml

Type of change

  • workflows

Memory requirements

Performance

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Title of PR is suitable for corresponding CHANGELOG entry

Does this change modify the behaviour of other functions? If so, which?

no

@ghost
Copy link

ghost commented Mar 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:python. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-actions
Copy link
Contributor

Thank you for the PR!

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1127 (b3958da) into release/1.2.x (4368ee4) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           release/1.2.x    #1127      +/-   ##
=================================================
- Coverage          91.80%   91.80%   -0.01%     
=================================================
  Files                 65       65              
  Lines              10075    10038      -37     
=================================================
- Hits                9249     9215      -34     
+ Misses               826      823       -3     
Flag Coverage Δ
unit 91.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Thank you for the PR!

@mtar mtar marked this pull request as ready for review March 22, 2023 09:33
@mtar mtar requested a review from ClaudiaComito March 22, 2023 09:53
@github-actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito added this to the 1.3.0 milestone Mar 29, 2023
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mtar !

@ClaudiaComito ClaudiaComito self-assigned this Apr 18, 2023
@ClaudiaComito ClaudiaComito merged commit 271d8b8 into release/1.2.x Apr 18, 2023
ClaudiaComito added a commit that referenced this pull request May 23, 2023
* Support latest PyTorch release

* Update setup.py

* Specify allclose tolerance in test_inv()

* Increase allclose tolerance in test_inv

* Increase allclose tolerance for distributed floating-point operations

* fix working branches selection

* add pr workflow (#1127)

* add pr workflow

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update README.md

* Update .gitlab-ci.yml

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Support latest PyTorch release

* expand version check to torch 2

* dndarray.item() to return ValueError if dndarray.size > 1

* increase min pytorch & delete old code

* delete code for python < 3.7

* remove pytorch 1.7 from test matrix

* call bitwise functions instead of tensor builtins

* Fixed bugs due to behaviour change in torch.nn.Module.zero_grad() and torch.Tensor.item() in torch 2.0 (#1149)

* Support latest PyTorch release

* Fixed bug in optimizer due to change in default behaviour of zero_grad() function in torch 2.0

* Fixed bug in due to change in behaviour of torch.Tensor.item() in torch 2.0

* Fixed version in setup.py

* Modified tests to work for torch 1.0 also

---------

Co-authored-by: ClaudiaComito <ClaudiaComito@users.noreply.github.com>

* update test_item

* replace python 3.7 with 3.10 in tests

* increase min python + numpy

* Add Interoperability chapter

* update deprecated functions

* switch ref

* bump pytorch version

* define branch name for Pytorch release PR

* Add torch 2.0.0 to matrix

* Test latest torch patch, fix 1.8 entries

---------

Co-authored-by: ClaudiaComito <ClaudiaComito@users.noreply.github.com>
Co-authored-by: Michael Tarnawa <m.tarnawa@fz-juelich.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ashwath V A <73862377+Mystic-Slice@users.noreply.github.com>
@mtar mtar deleted the enhancement/1113-pr-action-release branch February 28, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants