Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAIR-RS and best practice badges #1143

Merged
merged 19 commits into from
Aug 7, 2023
Merged

FAIR-RS and best practice badges #1143

merged 19 commits into from
Aug 7, 2023

Conversation

JuanPedroGHM
Copy link
Member

Description

The goal is to make HeAT FAIR-RS compliant according to https://fair-software.eu/. We already cover most of the requisites, so we just need to show it with some new shiny badges.

Issue/s resolved: #

Changes proposed:

Type of change

  • Documentation update

Due Diligence

  • Documentation updated (if needed)
  • Title of PR is suitable for corresponding CHANGELOG entry

Does this change modify the behaviour of other functions? If so, which?

no

@ghost
Copy link

ghost commented Apr 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

Thank you for the PR!

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1143 (0c4e8d4) into main (549deb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          75       75           
  Lines       10705    10705           
=======================================
  Hits         9866     9866           
  Misses        839      839           
Flag Coverage Δ
unit 92.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrfh92
Copy link
Collaborator

mrfh92 commented Jul 27, 2023

I think this is sth for the next PR talk as well

@mrfh92 mrfh92 added this to the 1.4.0 milestone Jul 27, 2023
@mrfh92 mrfh92 added the PR talk label Jul 27, 2023
@github-actions
Copy link
Contributor

Thank you for the PR!

1 similar comment
@github-actions
Copy link
Contributor

Thank you for the PR!

@github-actions
Copy link
Contributor

Thank you for the PR!

@github-actions
Copy link
Contributor

Thank you for the PR!

1 similar comment
@github-actions
Copy link
Contributor

Thank you for the PR!

@mrfh92
Copy link
Collaborator

mrfh92 commented Jul 27, 2023

@ClaudiaComito as mentioned above by @JuanPedroGHM this needs to be done by the owner (you?): https://bestpractices.coreinfrastructure.org/en

@ClaudiaComito ClaudiaComito modified the milestones: 1.4.0, Repo Clean-Up Jul 31, 2023
@github-actions
Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, thanks a lot @JuanPedroGHM . Only think we'll be missing after the merge is the "checklist" item, correct? https://fair-software.eu/recommendations/checklist/ OK got it :)

I have already tried to grant access earlier today, but I get an error (page not found) after granting access, will try again later

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the OpenSSF best practices badge to the readme.

@github-actions
Copy link
Contributor

Thank you for the PR!

@github-actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito added the documentation Anything related to documentation label Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thank you for the PR!

Reorganize badges order and labels on repo landing page
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Thank you for the PR!

@JuanPedroGHM JuanPedroGHM marked this pull request as ready for review August 7, 2023 07:46
@ClaudiaComito ClaudiaComito merged commit 7482f14 into main Aug 7, 2023
44 checks passed
@mtar mtar deleted the docs/fair-tag branch February 28, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to documentation merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants