Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support amd HIP #1152

Merged
merged 7 commits into from
May 22, 2023
Merged

support amd HIP #1152

merged 7 commits into from
May 22, 2023

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented May 17, 2023

Description

This Pull Request skips some tests such that it can be run on AMD GPU. Additionally branches starting with 'support/' are tested on push events.

Issue/s resolved: #694

Changes proposed:

  • skip tests using special cuda libraries
  • push trigger event on support branch

Type of change

  • testing

Memory requirements

Performance

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Title of PR is suitable for corresponding CHANGELOG entry

Does this change modify the behaviour of other functions? If so, which?

yes / no

@mtar mtar added the testing Implementation of tests, or test-related issues label May 17, 2023
@ghost
Copy link

ghost commented May 17, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@mtar mtar marked this pull request as ready for review May 17, 2023 13:47
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mtar ! Can you create an issue with the HIP QR error message, so we can follow up on it?

@ClaudiaComito ClaudiaComito added this to the 1.3.0 milestone May 22, 2023
@mtar mtar merged commit f400d14 into main May 22, 2023
@mtar mtar deleted the support/694-amd-hip branch May 22, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HW:ROCm testing Implementation of tests, or test-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the HIP backend
2 participants