Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to automated branch creation on Issue assignment #1190

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

ClaudiaComito
Copy link
Contributor

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Small fixes to automated branch creation on Issue assignment.

Issue/s resolved: #1182

Changes proposed:

  • introduced workflows prefix
  • modified branch naming scheme to match what we used so far
  • updated Quick_start.md accordingly

Type of change

Documentation update

Memory requirements

NA

Performance

NA

Does this change modify the behaviour of other functions? If so, which?

no

@ClaudiaComito ClaudiaComito added documentation Anything related to documentation workflows labels Aug 4, 2023
@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thank you for the PR!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thank you for the PR!

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1190 (13aa86d) into main (1524a76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1190   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          75       75           
  Lines       10705    10705           
=======================================
  Hits         9866     9866           
  Misses        839      839           
Flag Coverage Δ
unit 92.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

quick_start.md Outdated Show resolved Hide resolved
mrfh92
mrfh92 previously approved these changes Aug 4, 2023
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me; I only have one comment (see above).

Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thank you for the PR!

@ClaudiaComito ClaudiaComito merged commit 549deb9 into main Aug 4, 2023
44 checks passed
@mtar mtar deleted the issue-1182-_Bug_Test_automated_branch_creation branch February 28, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to documentation workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Test automated branch creation
2 participants