Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate data and computation in benchmarks #1202

Merged

Conversation

JuanPedroGHM
Copy link
Member

Description

Includes the changes done #1158, and includes updates to accommodate the new version of perun. Created a new branch and pull request because I messed up while rebasing.

  • Removed data generation from the benchmarked functions.
  • Updated perun api.
  • Seed fixed in main script
  • Device can be set with ENV variables

Issue/s resolved: #1157

Does this change modify the behaviour of other functions? If so, which?

no

@ghost
Copy link

ghost commented Aug 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

Thank you for the PR!

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1202 (93e3d75) into main (089ab2f) will not change coverage.
The diff coverage is n/a.

❗ Current head 93e3d75 differs from pull request most recent head 3ef706d. Consider uploading reports for the commit 3ef706d to get more accurate results

@@           Coverage Diff           @@
##             main    #1202   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files          75       75           
  Lines       10699    10699           
=======================================
  Hits         9864     9864           
  Misses        835      835           
Flag Coverage Δ
unit 92.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JuanPedroGHM JuanPedroGHM changed the title Refactor/separate data and computation in benchmarks Separate data and computation in benchmarks Aug 23, 2023
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito merged commit c43a240 into main Aug 29, 2023
43 checks passed
@mtar mtar removed the PR talk label Sep 11, 2023
@mtar mtar deleted the refactor/separate_data_and_computation_in_benchmarks branch February 28, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Continuous Benchmarking might measure wrong times
3 participants