Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some NumPy deprecations in the core tests. #1315

Merged

Conversation

FOsterfeld
Copy link
Member

@FOsterfeld FOsterfeld commented Jan 2, 2024

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@ghost
Copy link

ghost commented Jan 2, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Thank you for the PR!

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Thank you for the PR!

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Thank you for the PR!

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8fd26a) 91.81% compared to head (6a5115c) 91.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          79       79           
  Lines       11463    11463           
=======================================
  Hits        10525    10525           
  Misses        938      938           
Flag Coverage Δ
unit 91.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FOsterfeld FOsterfeld self-assigned this Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Thank you for the PR!

Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation warnings do not appear anymore. Thanks 👍

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Thank you for the PR!

@mrfh92 mrfh92 self-requested a review January 8, 2024 09:03
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrfh92 mrfh92 self-requested a review January 8, 2024 09:05
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Thank you for the PR!

Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 merged commit 983e12d into main Jan 22, 2024
10 checks passed
@mtar mtar deleted the bugs/1232-_Bug_Ensure_NumPy-compatibility_of_test_statistics_py branch March 6, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants