-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some NumPy deprecations in the core tests. #1315
Fix some NumPy deprecations in the core tests. #1315
Conversation
Thank you for the PR! |
1 similar comment
Thank you for the PR! |
Thank you for the PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 79 79
Lines 11463 11463
=======================================
Hits 10525 10525
Misses 938 938
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecation warnings do not appear anymore. Thanks 👍
…_test_statistics_py
Thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…_test_statistics_py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you for the PR! |
…_test_statistics_py
Thank you for the PR! |
Due Diligence
main
for new features, latest release branch (e.g.release/1.3.x
) for bug fixesDescription
Issue/s resolved: #
Changes proposed:
Type of change
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no