Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release/1.4.x] Bugfix: _like factories now default to same device as input DNDarray #1472

Merged
merged 15 commits into from
May 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 7, 2024

Description

Backport of #1443 to release/1.4.x.

Hoppe and others added 14 commits May 7, 2024 08:59
(cherry picked from commit b044108)
(cherry picked from commit 32e2b3a)
(cherry picked from commit f86b47b)
(cherry picked from commit 1aaa021)
(cherry picked from commit 52361d8)
(cherry picked from commit 8f0db24)
(cherry picked from commit 874d397)
(cherry picked from commit 2d1bc86)
(cherry picked from commit 4525b71)
(cherry picked from commit d5970e2)
(cherry picked from commit 2112a11)
(cherry picked from commit 90902c6)
(cherry picked from commit 91f0b4b)
@mtar mtar added the bug Something isn't working label May 7, 2024
(cherry picked from commit becf183)
Copy link
Contributor Author

github-actions bot commented May 7, 2024

Thank you for the PR!

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (f638c93) to head (4d4a370).

Additional details and impacted files
@@              Coverage Diff               @@
##           release/1.4.x    #1472   +/-   ##
==============================================
  Coverage          91.59%   91.59%           
==============================================
  Files                 80       80           
  Lines              11647    11652    +5     
==============================================
+ Hits               10668    10673    +5     
  Misses               979      979           
Flag Coverage Δ
unit 91.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtar mtar merged commit 1403250 into release/1.4.x May 7, 2024
7 checks passed
@mtar mtar deleted the backport-1443-to-release/1.4.x branch May 7, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants