[Backport release/1.4.x] Bugfix: _like factories now default to same device as input DNDarray
#1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
(cherry picked from commit 32e2b3a)
(cherry picked from commit 3bfdbeb)
(cherry picked from commit f86b47b)
(cherry picked from commit 1aaa021)
(cherry picked from commit 8f0db24)
(cherry picked from commit 874d397)
(cherry picked from commit 2d1bc86)
(cherry picked from commit 4525b71)
(cherry picked from commit d5970e2)
(cherry picked from commit 2112a11)
(cherry picked from commit 90902c6)
(cherry picked from commit 91f0b4b)
4 tasks
mtar
approved these changes
May 7, 2024
(cherry picked from commit becf183)
|
Thank you for the PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.4.x #1472 +/- ##
==============================================
Coverage 91.59% 91.59%
==============================================
Files 80 80
Lines 11647 11652 +5
==============================================
+ Hits 10668 10673 +5
Misses 979 979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #1443 to
release/1.4.x.