Support multiple axes for ht.percentile

[ClaudiaComito]

Due Diligence

• General:
  • title of the PR is suitable to appear in the Release Notes
• Implementation:
  • unit tests: all split configurations tested
  • unit tests: multiple dtypes tested
  • documentation updated where needed

Description

No changes in functionality here, Tuple axes are now supported. The function is just as slow as lamented in #1389 , but it has been refactored for better readability.

Issue/s resolved: None
Related issue: #1420

Changes proposed:

• refactor and use indexing instead of Bcast
• support tuple axes in ht.percentile
• support tuple axes in ht.expand_dims
  ADDED SEPT 4 2024:
• (following discussion with @JuanPedroGHM ) if reshape of a distributed array involves reducing or expanding dimensions, the output (reshaped array) will be distributed along axis 0 by default. Users can always set the new_axis argument to a different split axis.

Type of change

New feature (non-breaking change which adds functionality) plus refactoring

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes, reshape, see above

[github-actions]

Thank you for the PR!

[codecov]

Codecov Report

Attention: Patch coverage is 99.35484% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.07%. Comparing base (d61782a) to head (e77f1ff).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
heat/core/statistics.py	99.07%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1510   +/-   ##
=======================================
  Coverage   92.06%   92.07%           
=======================================
  Files          83       83           
  Lines       12194    12196    +2     
=======================================
+ Hits        11227    11230    +3     
+ Misses        967      966    -1     

Flag	Coverage Δ
unit	92.07% <99.35%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Thank you for the PR!

[github-actions]

Thank you for the PR!

[github-actions]

Thank you for the PR!

[github-actions]

Thank you for the PR!

[github-actions]

Thank you for the PR!

[github-actions]

Thank you for the PR!

[ClaudiaComito]

@mrfh92 @JuanPedroGHM I think I'm done here.

@mrfh92 I expanded the tests to cover tuple axes for sketched percentile, and also writing to out buffer. @JuanPedroGHM and I also decided to make some changes in reshape, see expanded description above. Let me know if something's missing, thanks!

[mrfh92]

My change requests have been addressed.
Thanks for the work 👍

[github-actions]

Thank you for the PR!

[ClaudiaComito]

@mrfh92 I made small edits to the docs to trigger the pipeline again, codecov had gotten stuck. I'm afraid you need to approve again, thanks!