Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyTorch 2.3.0 (#1467) #1512

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jun 5, 2024

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Backport of PR #1467 into release:

Changes proposed:

  • Support latest PyTorch release
  • Update ci.yaml
  • pytorch: add v2.2, drop v1.11
  • fix type bug
  • delete legacy code
  • ci: explicit version numbers

Type of change

interoperability / bug fix

* Support latest PyTorch release

* Update ci.yaml

* pytorch: add v2.2, drop v1.11

* fix type bug

* delete legacy code

* ci: explicit version numbers

---------

Co-authored-by: ClaudiaComito <39374113+ClaudiaComito@users.noreply.github.com>
Co-authored-by: Michael Tarnawa <m.tarnawa@fz-juelich.de>
(cherry picked from commit ee0d72a)
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Thank you for the PR!

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (6112775) to head (4ae77a5).

Additional details and impacted files
@@                Coverage Diff                @@
##           release/1.4.x    #1512      +/-   ##
=================================================
+ Coverage          91.58%   91.77%   +0.18%     
=================================================
  Files                 80       80              
  Lines              11652    11640      -12     
=================================================
+ Hits               10672    10683      +11     
+ Misses               980      957      -23     
Flag Coverage Δ
unit 91.77% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mtar !

@ClaudiaComito ClaudiaComito merged commit 935fa5c into release/1.4.x Jun 5, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants