Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_npy_from_path: improve load balancing #1602

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Reisii
Copy link
Collaborator

@Reisii Reisii commented Aug 7, 2024

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Issue/s resolved: #1601

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

no

@Reisii Reisii linked an issue Aug 7, 2024 that may be closed by this pull request
@Reisii Reisii requested a review from mrfh92 August 7, 2024 13:16
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Thank you for the PR!

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (ba3f4db) to head (0d0e575).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1602   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files          83       83           
  Lines       12109    12110    +1     
=======================================
+ Hits        11146    11147    +1     
  Misses        963      963           
Flag Coverage Δ
unit 92.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrfh92 mrfh92 changed the title More optimal Distribution of Files across ranks load_npy_from_path: improve load balancing Aug 8, 2024
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍
Thanks :)

@mrfh92 mrfh92 merged commit 7acb068 into main Aug 9, 2024
34 checks passed
@mrfh92 mrfh92 deleted the 1601-bug-inefficient-distribution-of-files branch August 9, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inefficient Distribution of Files
2 participants