Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dalcin et al 2018 reference to manipulations._axis2axisResplit #1695

Merged

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Oct 28, 2024

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@ClaudiaComito ClaudiaComito added the documentation Anything related to documentation label Oct 28, 2024
@ClaudiaComito ClaudiaComito added this to the 1.5.1 milestone Oct 28, 2024
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (ac392b5) to head (97af69c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files          83       83           
  Lines       12209    12209           
=======================================
  Hits        11254    11254           
  Misses        955      955           
Flag Coverage Δ
unit 92.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClaudiaComito ClaudiaComito merged commit 99f6f4b into main Oct 28, 2024
42 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
(cherry picked from commit 99f6f4b)
Copy link
Contributor

Successfully created backport PR for release/1.5.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/1.5.x documentation Anything related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants