Features/37 minimum #324
Features/37 minimum #324
Conversation
Added test case for specified output buffer.
…alytics/heat into features/37-minimum
…alytics/heat into features/37-minimum
…ests accordingly.
… and MPI.MIN. * Raising NotImplementedError for x1.split != x2.split and x1.device != x2.device.
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 96.85% 96.87% +0.02%
==========================================
Files 49 49
Lines 7754 7875 +121
==========================================
+ Hits 7510 7629 +119
- Misses 244 246 +2
Continue to review full report at Codecov.
|
| result._DNDarray__dtype = lresult._DNDarray__dtype | ||
| result._DNDarray__split = split | ||
|
|
||
| if out is not None: |
There was a problem hiding this comment.
is it possible to combine this if out and the other one?
There was a problem hiding this comment.
I'm not sure how, as one of them only writes out in the distributed case, the other one in the non-distributed case. If you can think of something, let me know.
heat/core/statistics.py
Outdated
| @@ -569,6 +704,15 @@ def mpi_argmin(a, b, _): | |||
|
|
|||
| MPI_ARGMIN = MPI.Op.Create(mpi_argmin, commute=True) | |||
|
|
|||
| # # TODO: implement mpi_minimum | |||
There was a problem hiding this comment.
Does this need to be here? this could be put in an issue
There was a problem hiding this comment.
Sorry about this, it's a leftover from the attempted implementation through __reduce_op(), I removed it already.
Now addressing the case where x1.split != x2.split.