Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/284 add to exponents and logarithms #327

Merged
merged 8 commits into from
Jul 12, 2019

Conversation

krajsek
Copy link
Member

@krajsek krajsek commented Jul 11, 2019

Add log1p + unit tests + remove some duplicate unit tests

@krajsek krajsek requested a review from coquelin77 July 11, 2019 11:34
@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

Merging #327 into master will decrease coverage by 0.01%.
The diff coverage is 98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   96.78%   96.77%   -0.02%     
==========================================
  Files          53       53              
  Lines        8128     8216      +88     
==========================================
+ Hits         7867     7951      +84     
- Misses        261      265       +4
Impacted Files Coverage Δ
heat/core/exponential.py 100% <100%> (ø) ⬆️
heat/core/tests/test_rounding.py 100% <100%> (ø) ⬆️
heat/core/tests/test_exponential.py 100% <100%> (ø) ⬆️
heat/core/dndarray.py 95.03% <100%> (+0.05%) ⬆️
heat/core/rounding.py 93.93% <100%> (+0.39%) ⬆️
heat/core/communication.py 92.64% <75%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d89ea...b5d6947. Read the comment docs.

Copy link
Member

@coquelin77 coquelin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks!

@coquelin77 coquelin77 merged commit 4537d91 into master Jul 12, 2019
@coquelin77 coquelin77 deleted the features/284-add-to-exponents-and-logarithms branch July 12, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants