Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/326 maximum #328

Merged
merged 4 commits into from
Jul 16, 2019
Merged

Features/326 maximum #328

merged 4 commits into from
Jul 16, 2019

Conversation

ClaudiaComito
Copy link
Contributor

Analogue implementation to ht.minimum(). Solves Issue #326.

@codecov-io
Copy link

codecov-io commented Jul 12, 2019

Codecov Report

Merging #328 into master will increase coverage by 0.02%.
The diff coverage is 98.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   96.77%   96.79%   +0.02%     
==========================================
  Files          53       53              
  Lines        8216     8336     +120     
==========================================
+ Hits         7951     8069     +118     
- Misses        265      267       +2
Impacted Files Coverage Δ
heat/core/tests/test_statistics.py 100% <100%> (ø) ⬆️
heat/core/statistics.py 96.53% <96.07%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4537d91...be0b56c. Read the comment docs.

@ClaudiaComito
Copy link
Contributor Author

I'm going to go ahead and merge this as it's identical to ht.minimum()

@ClaudiaComito ClaudiaComito merged commit 4a56ff2 into master Jul 16, 2019
@ClaudiaComito ClaudiaComito deleted the features/326-maximum branch July 16, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants