-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 238 load_cvs() #330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 97.06% 97.06% +<.01%
==========================================
Files 53 53
Lines 9265 9417 +152
==========================================
+ Hits 8993 9141 +148
- Misses 272 276 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issues, potentially something to discuss
Targets issue #238.
Loading a CSV works. The CSV is always distributed along the 0 axis because only this way the file can be read in parallel.
It currently does not work with types other than
float32
because of the use ofbalance_()
and issue #329.Question is, should the saving also be implemented or is this another issue?