Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 238 load_cvs() #330

Merged
merged 16 commits into from
Aug 2, 2019
Merged

Feature 238 load_cvs() #330

merged 16 commits into from
Aug 2, 2019

Conversation

TheSlimvReal
Copy link
Contributor

@TheSlimvReal TheSlimvReal commented Jul 15, 2019

Targets issue #238.

Loading a CSV works. The CSV is always distributed along the 0 axis because only this way the file can be read in parallel.
It currently does not work with types other than float32 because of the use of balance_() and issue #329.

Question is, should the saving also be implemented or is this another issue?

@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #330 into master will increase coverage by <.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   97.06%   97.06%   +<.01%     
==========================================
  Files          53       53              
  Lines        9265     9417     +152     
==========================================
+ Hits         8993     9141     +148     
- Misses        272      276       +4
Impacted Files Coverage Δ
heat/core/tests/test_io.py 93% <100%> (+1.2%) ⬆️
heat/core/io.py 90.25% <94.59%> (+2.82%) ⬆️
heat/core/dndarray.py 95.56% <0%> (+0.19%) ⬆️
heat/core/communication.py 93.96% <0%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1722a65...93548ff. Read the comment docs.

Copy link
Member

@Markus-Goetz Markus-Goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues, potentially something to discuss

heat/core/io.py Outdated Show resolved Hide resolved
heat/core/io.py Outdated Show resolved Hide resolved
heat/core/io.py Outdated Show resolved Hide resolved
heat/core/io.py Outdated Show resolved Hide resolved
heat/core/io.py Outdated Show resolved Hide resolved
@Markus-Goetz Markus-Goetz merged commit c3f164d into master Aug 2, 2019
@Markus-Goetz Markus-Goetz deleted the feature/238_load_csv branch August 2, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants