Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mean support for ints on local level, also a correctness test #350

Merged
merged 5 commits into from
Jul 31, 2019

Conversation

coquelin77
Copy link
Member

Description

adds support for ints to mean and variance. The problem was at the pytorch level, the solution was to cast the array to a float. all tests run without failure

Fixes: #349 (and parallel problem with var although it was not previously pointed out)

Changes proposed:

  • casting of the torch tensor to float in the non-distributed case for both mean and var (has no effect if the tensor is already a float)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Have you handled and tested all split configurations?
Yes

@codecov-io
Copy link

Codecov Report

Merging #350 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   96.95%   96.96%   +<.01%     
==========================================
  Files          53       53              
  Lines        8913     8917       +4     
==========================================
+ Hits         8642     8646       +4     
  Misses        271      271
Impacted Files Coverage Δ
heat/core/tests/test_statistics.py 100% <100%> (ø) ⬆️
heat/core/statistics.py 96.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aed5cb...42bc405. Read the comment docs.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@coquelin77 coquelin77 merged commit c0f9525 into master Jul 31, 2019
@coquelin77 coquelin77 deleted the bug/349-mean_int_not_distributed branch July 31, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ht.mean() won't take int input in non-distributed case
3 participants