Features/32 diff #388
Merged
Features/32 diff #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 17, 2019 19:48
diff complete, test implemented running for all
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 97.34% 97.38% +0.04%
==========================================
Files 53 53
Lines 10395 10481 +86
==========================================
+ Hits 10119 10207 +88
+ Misses 276 274 -2
Continue to review full report at Codecov.
|
Markus-Goetz
requested changes
Sep 24, 2019
heat/core/arithmetics.py
Outdated
| if n < 0: | ||
| raise ValueError('diff requires that n be a positive number, got {}'.format(n)) | ||
| if not isinstance(axis, int): | ||
| raise ValueError('axis must be an integer, is currently {}'.format(type(axis))) |
There was a problem hiding this comment.
This should be sanitize_axis()
heat/core/tests/test_statistics.py
Outdated
| @@ -279,6 +279,7 @@ def test_average(self): | |||
|
|
|||
| # check weighted average over all float elements of split 3d tensor, across split axis | |||
| random_volume = ht.array(torch.randn((3, 3, 3), dtype=torch.float64), is_split=1) | |||
| # random_volume = ht.random.randn(3, 3, 3, dtype=ht.float64, split=) | |||
Markus-Goetz
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue/s is/are fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #32
Changes proposed:
Type of change
Please delete options that are not relevant.
Have you handled and tested all split configurations?
yes