Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lasso tests on GPU #463

Merged
merged 4 commits into from
Jan 24, 2020
Merged

fix lasso tests on GPU #463

merged 4 commits into from
Jan 24, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jan 22, 2020

Description

Fixes the tests in test_lasso.py such that it completes on GPU.

Issue/s resolved: #462

Changes proposed:

  • adding device parameters
  • numpy() -> cpu().numpy()

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #463 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   96.68%   96.69%   +<.01%     
==========================================
  Files          57       57              
  Lines       12134    12147      +13     
==========================================
+ Hits        11732    11745      +13     
  Misses        402      402
Impacted Files Coverage Δ
heat/core/tests/test_manipulations.py 99.26% <100%> (ø) ⬆️
heat/core/manipulations.py 99.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0ebb0...61c163e. Read the comment docs.

Copy link
Member

@coquelin77 coquelin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update changelog.md with the change

@coquelin77 coquelin77 merged commit 2bae3f7 into master Jan 24, 2020
@coquelin77 coquelin77 deleted the bug/462-test_lasso branch January 24, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_lasso fails on GPU
2 participants