Bug/464 unique torch tensor #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 96.68% 96.69% +<.01%
==========================================
Files 57 57
Lines 12134 12147 +13
==========================================
+ Hits 11732 11745 +13
Misses 402 402
Continue to review full report at Codecov.
|
mtar
reviewed
Jan 23, 2020
heat/core/manipulations.py
Outdated
| a._DNDarray__array, sorted=sorted, return_inverse=return_inverse, dim=axis | ||
| ) | ||
| if isinstance(torch_output, tuple): | ||
| heat_output = tuple(factories.array(i, dtype=a.dtype) for i in torch_output) |
There was a problem hiding this comment.
different number of arguments?
There was a problem hiding this comment.
also the array calls should have a device parameter
| if isinstance(torch_output, tuple): | ||
| heat_output = tuple(factories.array(i, dtype=a.dtype) for i in torch_output) | ||
| else: | ||
| heat_output = factories.array(torch_output, dtype=a.dtype, split=None, device=a.device) |
There was a problem hiding this comment.
different number of arguments?
coquelin77
requested changes
Jan 23, 2020
heat/core/manipulations.py
Outdated
| a._DNDarray__array, sorted=sorted, return_inverse=return_inverse, dim=axis | ||
| ) | ||
| if isinstance(torch_output, tuple): | ||
| heat_output = tuple(factories.array(i, dtype=a.dtype) for i in torch_output) |
There was a problem hiding this comment.
also the array calls should have a device parameter
heat/core/manipulations.py
Outdated
| a._DNDarray__array, sorted=sorted, return_inverse=return_inverse, dim=axis | ||
| ) | ||
| if isinstance(torch_output, tuple): | ||
| heat_output = tuple(factories.array(i, dtype=a.dtype) for i in torch_output) |
|
Thanks a lot @mtar and @coquelin77 , you're correct, I made the changes you requested, merging and closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Output of ht.unique(x) used to be a torch tensor or a tuple of torch tensors if
x.split is None, it is now either a heat tensor, or a tuple of heat tensors in all cases.Issue/s resolved: #464
Changes proposed:
Type of change
Remove irrelevant options:
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no