Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecastion Bugfix #478

Merged
merged 5 commits into from
Feb 7, 2020

Conversation

Cdebus
Copy link
Contributor

@Cdebus Cdebus commented Feb 7, 2020

Description

Fixed Typecasting if factories.array is handed a different dtype than the obj.dtype is

Issue/s resolved: #477

Changes proposed:

  • Addidtion to factories.array function

Type of change

Remove irrelevant options:

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • [x ] Multiple dtypes tested in relavent functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #478 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          60       60           
  Lines       12278    12281    +3     
=======================================
+ Hits        11876    11879    +3     
  Misses        402      402           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f3f45...3707b6c. Read the comment docs.

@coquelin77 coquelin77 merged commit 29be6aa into helmholtz-analytics:master Feb 7, 2020
@Cdebus Cdebus deleted the bug/477-Typecasting branch April 7, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typecasting in heat.array ignores dtype argument and casts from torch array type
2 participants