-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version in setup.py #506
Fix version in setup.py #506
Conversation
The old code adjusted sys.path and imported heat/core/version which implicitly imports heat itself. This leads to two problems: * setup tools cannot run without dependencies, e.g. just "python setup.py --version" fails * setuptools skip copying the complete heat code into the target directory in some cases as heat is already in sys.path
this is failing in pre-commit. please see the README for how to set this up |
this is still failing. is there any update on this? |
Bump |
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
+ Coverage 96.35% 96.38% +0.02%
==========================================
Files 75 75
Lines 14585 14481 -104
==========================================
- Hits 14054 13958 -96
+ Misses 531 523 -8
Continue to review full report at Codecov.
|
the line that you removed markus was there to satisfy flake. |
Hi Sorry, I didn't answer earlier. I'm not working most of the time, currently. So feel free to fix/improve this (thanks!). I can also look at it after Easter. |
Description
The old code adjusted sys.path and imported heat/core/version which
implicitly imports heat itself. This leads to two problems:
e.g. just "python setup.py --version" fails when py-torch is not available
directory in some cases as heat is already in sys.path, see https://setuptools.readthedocs.io/en/latest/setuptools.html:
The new variant directly executes the version.py file and avoids the problems above.
Issue/s resolved: #
Changes proposed:
Execute version.py in setup.py directly instead of importing heat.
Type of change
Remove irrelevant options:
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no